test_runner: create reporter destination directories - #65008
Open
Aston8 wants to merge 2 commits into
Open
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
avivkeller
reviewed
Aug 4, 2026
Co-authored-by: Aviv Keller <me@aviv.sh>
avivkeller
approved these changes
Aug 4, 2026
atlowChemi
approved these changes
Aug 6, 2026
Member
|
@Aston8 AFAICT your commit did not follow the guidelines (and is missing the Please reword the commit to make sure it meets the required standards, and then I would be happy to run CI |
|
Bump @Aston8 🙏 |
trivikr
changed the title
Member
|
@Aston8 Can you please sign the first commit and force push? It's required as per instructions
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65008 +/- ##
=======================================
Coverage 90.28% 90.28%
=======================================
Files 762 759 -3
Lines 247532 247608 +76
Branches 46690 46674 -16
=======================================
+ Hits 223475 223554 +79
- Misses 15491 15518 +27
+ Partials 8566 8536 -30
🚀 New features to boost your workflow:
|
MoLow
approved these changes
Aug 24, 2026
avivkeller
approved these changes
Aug 24, 2026
Member
|
Marked as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This creates missing parent directories before opening file-backed
--test-reporter-destinationoutputs, so paths likecoverage/lcov.infono longer fail with ENOENT when the parent directory does not exist.It also adds a regression test for a nested reporter destination path.
Fixes #64994